Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeshTools::n_connected_components calculations #4038

Open
wants to merge 13 commits into
base: devel
Choose a base branch
from

Conversation

roystgnr
Copy link
Member

I added this for some IGA mesh debugging, but it may be useful for others too.

I'm not sure if this is triggering in my real problems but it was
definitely screwing up my new unit tests.
We might be just *barely* connected by an arbitrary constraint matrix.
This is actually helping me track down the IGA issues I'm seeing...
I caught this when my approximated integral of error^2 turned out to be
*negative* and had a square root of NaN, but in general we're not doing
this integral in a nonlinear loop and we are doing it for error analysis
and we can afford to be more robust.
@moosebuild
Copy link

moosebuild commented Dec 18, 2024

Job Coverage, step Generate coverage on 4d61cc9 wanted to post the following:

Coverage

3fbbdd #4038 4d61cc
Total Total +/- New
Rate 62.31% 61.56% -0.75% 95.08%
Hits 72713 71876 -837 58
Misses 43991 44888 +897 3

Diff coverage report

Full coverage report

This comment will be updated on new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants