Skip to content

Commit

Permalink
Capture reason for "unknown" symbolization in traces
Browse files Browse the repository at this point in the history
Make sure that we capture the reason why a symbolization maps to
"unknown" in traces, as that can be relevant information when trying to
understand what the library is reporting.

Signed-off-by: Daniel Müller <deso@posteo.net>
  • Loading branch information
d-e-s-o committed Nov 14, 2024
1 parent 1848159 commit 8a78dd6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/symbolize/symbolizer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ impl SymbolizeHandler<'_> {
}

impl normalize::Handler<Reason> for SymbolizeHandler<'_> {
#[cfg_attr(feature = "tracing", crate::log::instrument(skip_all, fields(addr = format_args!("{_addr:#x}"))))]
#[cfg_attr(feature = "tracing", crate::log::instrument(skip_all, fields(addr = format_args!("{_addr:#x}"), ?reason)))]
fn handle_unknown_addr(&mut self, _addr: Addr, reason: Reason) {
let () = self.all_symbols.push(Symbolized::Unknown(reason));
}
Expand Down

0 comments on commit 8a78dd6

Please sign in to comment.