Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag ELF32 as unsupported #912

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Flag ELF32 as unsupported #912

merged 1 commit into from
Nov 19, 2024

Conversation

d-e-s-o
Copy link
Collaborator

@d-e-s-o d-e-s-o commented Nov 19, 2024

We don't currently support ELF32 symbol sources, but we don't detect them either and report a proper error. Rather, we just treat them as ELF64, which will turn bad sooner rather than later. With this change we make sure to detect ELF32 sources and report them as unsupported to make sure that there is no ambiguity what the problem is.

We don't currently support ELF32 symbol sources, but we don't detect
them either and report a proper error. Rather, we just treat them as
ELF64, which will turn bad sooner rather than later.
With this change we make sure to detect ELF32 sources and report them as
unsupported to make sure that there is no ambiguity what the problem is.

Signed-off-by: Daniel Müller <deso@posteo.net>
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.54%. Comparing base (77caf3f) to head (7b350f3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/elf/parser.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #912      +/-   ##
==========================================
- Coverage   94.54%   94.54%   -0.01%     
==========================================
  Files          57       57              
  Lines       10218    10229      +11     
==========================================
+ Hits         9661     9671      +10     
- Misses        557      558       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@d-e-s-o d-e-s-o merged commit 2b40049 into libbpf:main Nov 19, 2024
41 checks passed
@d-e-s-o d-e-s-o deleted the topic/elf32 branch November 19, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant