Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add cargo audit check #190

Closed
wants to merge 1 commit into from
Closed

CI: add cargo audit check #190

wants to merge 1 commit into from

Conversation

loshz
Copy link
Contributor

@loshz loshz commented Feb 19, 2022

Addresses: #187

This PR adds the cargo audit check to a GitHub actions workflow. It runs the check:

  • Every time the Cargo.lock or Cargo.toml files are updated in a PR.
  • Every Sunday at midnight.

Signed-off-by: Dan Bond danbond@protonmail.com

Copy link
Contributor

@mimullin-bbry mimullin-bbry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will appreciate the knowledge that libbpf-rs is periodically monitoring the cargo audit. I have a small nitpick that I think the changes should be squished into a single change.

Also, please see (#148) on how to format the commit message.

.github/workflows/audit.yml Show resolved Hide resolved
README.md Show resolved Hide resolved
Signed-off-by: Dan Bond <danbond@protonmail.com>
@loshz
Copy link
Contributor Author

loshz commented Feb 20, 2022

Going back to the drawing board on this as I tested it on a personal repo and the action assumes the Cargo.lock and Cargo.toml files are always in the root directory.

There is an open issue that discusses the related changes. I will keep an eye on it and comment on the initial issue #187

@loshz loshz closed this Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants