Update 'no messaging setup' message #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was found that if a ck_assert() or ck_abort() call was made when not running a test with srunner_run() that the current process would attempt to report a test failure to the process which started the test, of which none exists. As a result, finding no pipe file setup, the process aborts. This is all due to an API usage mistake, as ck_assert* and ck_abort() should not be called outside of a test or setup/teardown function. To make it more clear that if one hits this it is a API usage issue, changing the failure message which is reported.
Pro
added a commit
to open62541/open62541
that referenced
this pull request
Jan 3, 2019
ck_assert can only be called while a test is running. See libcheck/check#18 and libcheck/check#123 There was a race condition where the server loop tried to lock the mutex and assert the return value, although the tests already finished. Fixes #2331
Pro
added a commit
to open62541/open62541
that referenced
this pull request
Jan 3, 2019
ck_assert can only be called while a test is running. See libcheck/check#18 and libcheck/check#123 There was a race condition where the server loop tried to lock the mutex and assert the return value, although the tests already finished. Fixes #2331
Pro
added a commit
to open62541/open62541
that referenced
this pull request
Jan 3, 2019
ck_assert can only be called while a test is running. See libcheck/check#18 and libcheck/check#123 There was a race condition where the server loop tried to lock the mutex and assert the return value, although the tests already finished. Fixes #2331
Pro
added a commit
to open62541/open62541
that referenced
this pull request
Jan 3, 2019
ck_assert can only be called while a test is running. See libcheck/check#18 and libcheck/check#123 There was a race condition where the server loop tried to lock the mutex and assert the return value, although the tests already finished. Fixes #2331
Pro
added a commit
to open62541/open62541
that referenced
this pull request
Jan 3, 2019
ck_assert can only be called while a test is running. See libcheck/check#18 and libcheck/check#123 There was a race condition where the server loop tried to lock the mutex and assert the return value, although the tests already finished. Fixes #2331
Pro
added a commit
to open62541/open62541
that referenced
this pull request
Jan 3, 2019
ck_assert can only be called while a test is running. See libcheck/check#18 and libcheck/check#123 There was a race condition where the server loop tried to lock the mutex and assert the return value, although the tests already finished. Fixes #2331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was found that if a ck_assert() or ck_abort() call was made when not running a test
with srunner_run() that the current process would attempt to report a test
failure to the process which started the test, of which none exists. As a result,
finding no pipe file setup, the process aborts. This is all due to an API usage
mistake, as ck_assert* and ck_abort() should not be called outside of a
test or setup/teardown function.
To make it more clear that if one hits this it is a API usage issue, changing the
failure message which is reported.