Resolve warning in ptr macros with pointer to integer cast #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A warning from pointer-to-int-cast is being thrown due to the _ck_assert_ptr and _ck_assert_ptr_null macros casting a pointer to an integer value (for printing), but the pointer and integer sizes are different. This commit first casts the pointer to a uintptr_t value before casting it to an unsigned long.
brarcher
force-pushed
the
ptr_macros_warning
branch
from
83ff629
to
8c6788e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A warning from pointer-to-int-cast is being thrown due to the
_ck_assert_ptr and _ck_assert_ptr_null macros casting a pointer
to an integer value (for printing), but the pointer and integer
sizes are different.
This commit first casts the pointer to a uintptr_t value before
casting it to an unsigned long.
This is the change referenced in #280 and attributed to vtorri.