Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Bearer tokens #11

Closed
wants to merge 1 commit into from
Closed

Support Bearer tokens #11

wants to merge 1 commit into from

Conversation

n-g
Copy link

@n-g n-g commented Oct 12, 2023

While at it:

  • ensure absolute names are indeed absolute
  • fix error handling

Fixes #10

ensure absolute names are indeed absolute
fix error handling
@ofauchon
Copy link

Yes,

@n-g : I'd like to to test your PR with caddy webserver, but I can't solve this error.
Any idea how to go further ?

$ go version
go version go1.21.3 linux/amd64

 $ ~/go/bin/xcaddy build v2.7.5 --with github.com/n-g/libdns-gandi
...
2023/10/16 21:07:33 [INFO] exec (timeout=0s): /usr/bin/go get -d -v github.com/n-g/libdns-gandi github.com/caddyserver/caddy/v2@v2.7.5 
go: github.com/n-g/libdns-gandi@v0.0.0-20231012081002-090df437d112 found: parsing go.mod:
	module declares its path as: github.com/libdns/gandi
	        but was required as: github.com/n-g/libdns-gandi
go: github.com/n-g/libdns-gandi@upgrade (v0.0.0-20231012081002-090df437d112) requires github.com/n-g/libdns-gandi@v0.0.0-20231012081002-090df437d112: parsing go.mod:
	module declares its path as: github.com/libdns/gandi
	        but was required as: github.com/n-g/libdns-gandi
...

@n-g
Copy link
Author

n-g commented Oct 16, 2023

Yes,

@n-g : I'd like to to test your PR with caddy webserver, but I can't solve this error. Any idea how to go further ?

$ go version
go version go1.21.3 linux/amd64

 $ ~/go/bin/xcaddy build v2.7.5 --with github.com/n-g/libdns-gandi
...
2023/10/16 21:07:33 [INFO] exec (timeout=0s): /usr/bin/go get -d -v github.com/n-g/libdns-gandi github.com/caddyserver/caddy/v2@v2.7.5 
go: github.com/n-g/libdns-gandi@v0.0.0-20231012081002-090df437d112 found: parsing go.mod:
	module declares its path as: github.com/libdns/gandi
	        but was required as: github.com/n-g/libdns-gandi
go: github.com/n-g/libdns-gandi@upgrade (v0.0.0-20231012081002-090df437d112) requires github.com/n-g/libdns-gandi@v0.0.0-20231012081002-090df437d112: parsing go.mod:
	module declares its path as: github.com/libdns/gandi
	        but was required as: github.com/n-g/libdns-gandi
...

Right, I didn't change the go.mod to make the PR clean.

The best way to test this change is to check out github.com/n-g/libdns-gandi and then run
xcaddy build v2.7.5 --with github.com/libdns/gandi=. from that dir.

@obynio
Copy link
Collaborator

obynio commented Nov 7, 2023

Alright, just released recently the fix for the legacy certbot plugin, will work on this one asap.

@obynio obynio closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Keys are deprecated and should be replaced with Personal Access Tokens
3 participants