Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added versioning for S3 buckets #95

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added versioning for S3 buckets #95

wants to merge 2 commits into from

Conversation

nickalarson
Copy link

Added versioning for S3 buckets

fritzdj
fritzdj reviewed Jan 25, 2020
View reviewed changes
Copy link
Contributor

@fritzdj fritzdj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! I probably shouldn’t be an approver on this repo anymore, so will let @binaryblake or @rdbatch02 approve.

rdbatch
rdbatch requested changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@rdbatch rdbatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good but before we merge, could you add some logic that will suspend versioning if the configuration is removed/set to false on a bucket that had it enabled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritzdj fritzdj fritzdj left review comments

@rdbatch rdbatch rdbatch requested changes

@CWDoherty CWDoherty Awaiting requested review from CWDoherty

@binaryblake binaryblake Awaiting requested review from binaryblake

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickalarson @rdbatch @fritzdj