Made static members final so it's compatible with GWT. #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Derp, that what I fixed once... but #148 broke it again. Perhaps we need to add some comments over that methods to prevent such situation in future? |
|
Sorry about that, shouldn't have let that PR go it as it was. |
dsaltares
added a commit
that referenced
this pull request
Apr 9, 2015
Made static members final so it's compatible with GWT.
Maybe setup a jenkins job to compile an ashley GWT project every now and then? Most GWT errors surface during the compilation phase. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was trying to compile HTML with GWT in LibGDX but it complained about these members not being final. So I propose a small change to make it compatible. Please let me know if there are any reasons why this isn't a good idea. Thanks!