#50: Add convenience Entity.getFor(Class<? extends Component>) method #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -138,10 +138,24 @@ public void removeAll() { | |||
| } | |||
|
|
|||
| /** | |||
| * Retrieve a component from this {@link Entity} by class. | |||
| * | |||
| * <em>Note:</em> the preferred way of retrieving {@link Component}s is using {@link ComponentMapper}s. This method | |||
There was a problem hiding this comment.
Could you please add the reason for this? ComponentMapper has O(1) time for component retrieval while Entity.getComponent() has O(logn).
|
Other than these small comments, it looks good, thanks a lot! Will merge when resubmitted and rebased :-). |
mentioned in #50 - "New getComponent overload for Entity".
variables, and adding @SuppressWarnings where appropriate.
|
Sorry about those problems, I didn't mean to include the second commit in the first place; this is my first time using pull requests. I hope I've fixed it, if not I'll be available to sort my mess out! |
dsaltares
added a commit
that referenced
this pull request
Aug 30, 2014
#50: Add convenience Entity.getFor(Class<? extends Component>) method
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #50 - "New getComponent overload for Entity". Includes unit test for the new method. Unsure if adding this method pollutes the public API of the library, but since it's so simple to add here's the code anyway.