Fix parallel task join orchestrator hard-resets its children. #134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Parallel
task'sJoin
orchestrator callsreset()
on its children when completed. That renders them unusable for any further use within the tree. Looks like it's a simple mistake of callingreset()
(pool-related hard reset for task instances) instead ofresetTask()
(soft "restart" so the task can be run again).Here's a simple example that demonstrates the bug.
The
Repeat
task crashes on the second iteration at theAlwaysFail
decorator as its child was nullified by thereset()
call: