Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libgit2 cannot be initialized if git is not installed on a windows system #6225

Closed
edo9300 opened this issue Feb 19, 2022 · 2 comments · Fixed by #6228
Closed

Libgit2 cannot be initialized if git is not installed on a windows system #6225

edo9300 opened this issue Feb 19, 2022 · 2 comments · Fixed by #6228
Labels

Comments

@edo9300
Copy link

edo9300 commented Feb 19, 2022

After the changes in ecbb01f, the function git_win32__find_system_dirs will always fail if it can't find a git installation in PATH or from looking up the registry.

Reproduction steps

Attempt to initialize the library on a system that doesn't have any flavour of git installed.

Expected behavior

Unless other subsystems fails to initialize, the library should initialize correctly even without any git installed.

Actual behavior

The library fails to initialize.

Operating system(s) tested

Any Windows OS

@edo9300 edo9300 changed the title Libgit2 cannot initialize if git is not installed on a windows system Libgit2 cannot be initialized if git is not installed on a windows system Feb 19, 2022
@ethomson ethomson added the v1.4 label Feb 21, 2022
@ethomson
Copy link
Member

Yikes, many apologies. I opened #6228 which should fix this.

@edo9300
Copy link
Author

edo9300 commented Feb 21, 2022

Thank you, I won't be able to test this change for this week but it looks right. (In my local patch I ended up just disabling the error checking in the init function, with the same effect, and nothing wrong seemed to happen.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants