Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libgit2] Update to 1.4.2 #23184

Merged
merged 4 commits into from
Mar 4, 2022
Merged

[libgit2] Update to 1.4.2 #23184

merged 4 commits into from
Mar 4, 2022

Conversation

edo9300
Copy link
Contributor

@edo9300 edo9300 commented Feb 19, 2022

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libgit2/vcpkg.json

Valid values for the license field can be found in the documentation

@edo9300 edo9300 marked this pull request as draft February 19, 2022 19:26
@edo9300
Copy link
Contributor Author

edo9300 commented Feb 19, 2022

Changed this pr to a draft until this issue is figured out libgit2/libgit2#6225 (it was introduced with 1.4.0). Up to that point it would only be harmful for the developers to push a broken library.

@JonLiu1993 JonLiu1993 self-assigned this Feb 21, 2022
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Feb 21, 2022
@edo9300 edo9300 changed the title [libgit2] Update to 1.4.1 [libgit2] Update to 1.4.2 Feb 27, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libgit2/vcpkg.json

Valid values for the license field can be found in the documentation

@edo9300
Copy link
Contributor Author

edo9300 commented Feb 27, 2022

The bugfix version 1.4.2 got released and fixes the issue https://github.com/libgit2/libgit2/releases/tag/v1.4.2, updated the files to build 1.4.2 now

@edo9300 edo9300 marked this pull request as ready for review February 27, 2022 12:21
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 1b1ae50e1a69f7c659bd7d731e80b358d21c86ad -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 98d8569..fdc01d0 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3522,7 +3522,7 @@
     },
     "libgit2": {
       "baseline": "1.4.2",
-      "port-version": 1
+      "port-version": 0
     },
     "libgnutls": {
       "baseline": "3.6.15",
diff --git a/versions/l-/libgit2.json b/versions/l-/libgit2.json
index 17f4ad5..1704666 100644
--- a/versions/l-/libgit2.json
+++ b/versions/l-/libgit2.json
@@ -1,9 +1,9 @@
 {
   "versions": [
     {
-      "git-tree": "f6d98c06c540288fe7fee48b7ba4eb10309a0258",
+      "git-tree": "e036ca61d2e12b110c920cadf92f0aa4f39cac9b",
       "version-semver": "1.4.2",
-      "port-version": 1
+      "port-version": 0
     },
     {
       "git-tree": "37f2b6e92b60481a4db74de9da17385706d7d2e9",

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libgit2/vcpkg.json

Valid values for the license field can be found in the documentation

@JonLiu1993
Copy link
Member

@edo9300 ,Thanks for your pr, please run command "./vcpkg x-add-version libgit2 --overwrite-version" and commit again

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libgit2/vcpkg.json

Valid values for the license field can be found in the documentation

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Mar 4, 2022
@edo9300
Copy link
Contributor Author

edo9300 commented Mar 4, 2022

@edo9300 ,Thanks for your pr, please run command "./vcpkg x-add-version libgit2 --overwrite-version" and commit again

I missed the notification and I didn't notice your comment, sorry for that. Well since now you pushed it I guess I won't have to do anything.

@vicroms vicroms merged commit 59f1aea into microsoft:master Mar 4, 2022
@edo9300 edo9300 deleted the patch-1 branch March 4, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants