Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubuntu 18.04 lib #74

Merged
merged 1 commit into from
Nov 3, 2018
Merged

Add Ubuntu 18.04 lib #74

merged 1 commit into from
Nov 3, 2018

Conversation

bording
Copy link
Member

@bording bording commented Aug 15, 2018

As identified in dotnet/roslyn#29289, we need a separate library for Ubuntu 18.04 because of a change to the version of curl it ships.

@bording bording requested a review from ethomson August 15, 2018 03:09
@bording bording changed the title Add Ubuntu18.04 lib Add Ubuntu 18.04 lib Aug 15, 2018
@bording
Copy link
Member Author

bording commented Aug 15, 2018

It appears that the AppVeyor build is queued, but has never run.

@gep13
Copy link

gep13 commented Oct 21, 2018

Just wanted to touch base to see if this is something that can be pulled in? Thanks!

@ethomson @bording

@ethomson
Copy link
Member

Oy. I missed the notification for this. I guess we can pull this in, but holy cow do I want to rid ourselves of curl as a dependency as soon as humanly possible.

@gep13 You may also wish to check out libgit2/libgit2sharp#1618 which massively reduces the native dependencies. If you don't need networking, it would be nice to have the feedback on how it's working for you.

@gep13
Copy link

gep13 commented Oct 21, 2018

@ethomson thanks for the heads up, I will speak to the guys to see what they think.

@gep13
Copy link

gep13 commented Oct 21, 2018

@bording are you in a position to get this PR updated with the latest changes?

@bording
Copy link
Member Author

bording commented Oct 21, 2018

I won’t be able to resolve the merge conflicts until sometime tomorrow, but I’ll do that and we can get something out that has this included to at least unblock people until we can get the real fix in place!

@bording
Copy link
Member Author

bording commented Nov 3, 2018

I'm going to go ahead and merge this in, since it will unblock people until we have the real fix in place.

@bording bording merged commit 3b52079 into master Nov 3, 2018
@bording bording deleted the ubuntu-18 branch November 3, 2018 15:40
@bording
Copy link
Member Author

bording commented Nov 3, 2018

FYI, while testing the new lib, I've noticed something in the ldd output from an 18.04 VM that has me thinking I need to tweak something else here first, so I'm holding off on releasing the new nativebinaries package for now.

@bording
Copy link
Member Author

bording commented Nov 3, 2018

Nevermind, false alarm. I was accidentally running the wrong distro when I was doing my testing. When I actually used 18.04, everything looks fine.

Before pushing out a new version of the package, I'd like to finish testing on #79 and include that fix as well.

alex-weaver pushed a commit to alex-weaver/libgit2sharp.nativebinaries that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants