-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A new version please? (1.6.0 or something) #1069
Comments
Can you test the wheels https://github.com/libgit2/pygit2/actions/runs/711340943 ? |
Do you think you could make a PR with a unit test showing the error? |
ping @sathieu |
I'm just using the AUTO mode ( |
@feisuzhu Have you tried: proxy_opts.url = ffi.string(proxy) Ref: https://cffi.readthedocs.io/en/latest/ref.html#ffi-string-ffi-unpack |
No, no, no. Sorry for the noise ... |
Can confirm, I end up using |
@feisuzhu Have you tried: proxy_opts.url = ffi.new('char[]', proxy) ffi has a doc about memory ownership. Otherwise @jdavid, maybe we should drop support for |
IMHO I'll try again though. |
@feisuzhu Yes but the result of |
Did some experiment, found that it's |
Issue #1069 Test skipped as it triggers a bug in libgit2 causing a segfault. Just before this message is printed: src/transports/httpclient.c:926: proxy_connect: Assertion `client->state == DONE' failed.
Pushed a commit. Can you try with the wheels at https://github.com/libgit2/pygit2/actions/runs/774665500#artifacts ? |
We are expecting the proxy feature and it seems landed on master (#1063).
We have been waiting for a long time.
The text was updated successfully, but these errors were encountered: