Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the attribute to show the number of deltas/patches in one diff #281

Merged
merged 2 commits into from
Nov 1, 2013
Merged

add the attribute to show the number of deltas/patches in one diff #281

merged 2 commits into from
Nov 1, 2013

Conversation

alexband
Copy link

diff.size returns the number of deltas/patches of one diff

@jdavid
Copy link
Member

jdavid commented Oct 31, 2013

Since we have an iterator for patch in diff, it would be better to implement the length function, so it reads len(diff)

@jdavid
Copy link
Member

jdavid commented Oct 31, 2013

...instead of diff.size

@alexband
Copy link
Author

alexband commented Nov 1, 2013

@jdavid yes definitely better, see c0b1ab9

@jdavid jdavid merged commit c0b1ab9 into libgit2:master Nov 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexband @jdavid