Change refspec api

[jplana]

New attempt to provide refspec API with pygit, now using the new functions in libgit 0.20

It will expose:

the attributes

• fetch_refspecs
• push_refspecs

returning a list of strings with the refspecs

the methods

• set_fetch_refspecs([str])
• set_push_refspecs([str])

setting a list of strings a new refspecs

[carlosmn]

We have to_unicode for this which works across verisions.

[jdavid]

I think the API will be more intuitive if using a getset instead of a method, so:

refspecs = remote.fetch_refspecs
remote.fetch_refspecs = refspecs

Please update the documentation: docs/remotes.rst

Thanks!

[jplana]

I fixed most of the issues here, except probably the most important, the API. I see one problem with your proposal, while this would work:

remote.fetch_refspecs = ['xxx:xxxx','yyyy:zzzz']

This would not produce the expected result:

remote.fetch_refspecs[0] = 'xxxx:xxxx'

which a user of the library might use, as this is correct:

print remote.fetch_refspecs[0]
>>> 'xxxx:xxxx' 

IMHO a list where you could do

remote.fetch_refspecs[0] = 'xxxx:xxx'
# or even
remote.fetch_refspec.append('xxxx:xxxx')
remove.fetch_refspec.remove('yyyy:yyyy')

would be nicer, though I would leave it for a future PR (comments on this are welcome)

BTW I don't know if the attribute get_refspec makes sense anymore as the user can just "iterate" all refspecs using the refspec_count total but won't know if it's either a push or fetch refspec, not very useful.

[jdavid]

Then it should be Remote.get_fetch_refspecs() so the API is symmetric.

[jplana]

I think that fixes all the comments, adding better error treatment and making the API symmetric.

[jdavid]

After merging I get this error:

$ python setup.py build
[...]
x86_64-pc-linux-gnu-gcc -pthread -fPIC -I/usr/local/include -Iinclude -I/usr/include/python2.7 -c src/remote.c -o build/temp.linux-x86_64-2.7/src/remote.o
src/remote.c: In function ‘Remote_set_fetch_refspecs’:
src/remote.c:503:1: error: expected declaration or statement at end of input
error: command 'x86_64-pc-linux-gnu-gcc' failed with exit status 1

[jplana]

Upssss. Sorry about it.

[jplana]

Thanks a lot for your patience :-D

[jdavid]

Thank you for contributing.

Note I have fixed error handling. The Python functions already set an exception whenever there is an error, so you only need to set the exception for anything else.

[jplana]

I see the changes, thanks a lot. Still learning how to do proper python exceptions :-)