Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised that I never updated the references to the new method of updating. For now I've left
Reference.target=
as a proxy for the method call, but eventually we might like to remove it completely. Not specifying a message for the reflog significantly reduces the usability of the tools, so we should not provide a way to update which does not expose the existence of the reflog update.We will also need to get rid of
Reference.log_append()
as that is now done as part of the reference update (due to race conditions and correctness wrt locking) and you should never call it directly.