✨ Add libhal, util & mock to build & -fno-rtti #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having to add libhal, libhal-util and libhal-mock to each and every library project that uses the cmake build utility is tedious boilerplate that can be consolidated by this library. This will only affect `libhal_test_and_make_library` as the others need to be free to be used by `libhal`, `libhal-util`, and `libhal-mock` themselves. Add -fexceptions & -fno-rtti flags to the library build flags to ensure that unnecessary RTTI is not embedded into the library binaries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having to add libhal, libhal-util and libhal-mock to each and every library project that uses the cmake build utility is tedious boilerplate that can be consolidated by this library. This will only affect
libhal_test_and_make_libraryas the others need to be free to be used bylibhal,libhal-util, andlibhal-mockthemselves.Add -fexceptions & -fno-rtti flags to the library build flags to ensure that unnecessary RTTI is not embedded into the library binaries.