Initialized local variable as NULL #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uninitialized local variable has garbage data. It can cause a problem when ibus-hangul fails to load hanja-table. So this commit initializes local variable "list" as NULL.
|
각각 merge 안하고 master를 merge해서 적용했습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uninitialized local variable has garbage data. It can cause a problem when
ibus-hangul fails to load hanja-table. So this commit initializes local
variable "list" as NULL.
일반적으로 symbol.txt 로딩에 성공할 것이기 때문에, 대부분의 경우 해당 부분에 문제가 생기지는 않습니다. 하지만, symbol.txt 로딩에 실패할 경우 list가 NULL인지 검사하는 로직이 정상 작동하지 않습니다. 안전하게 list를 선언할 때 NULL로 초기화 하면 좋겠습니다.
감사합니다.