Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a WebTransport blog post #11

Merged
merged 24 commits into from
Dec 19, 2022
Merged

add a WebTransport blog post #11

merged 24 commits into from
Dec 19, 2022

Conversation

marten-seemann
Copy link
Contributor

@marten-seemann marten-seemann commented Dec 8, 2022

Remaining work:

  • Updated header image from Crcle
  • Updated diagrams

@p-shahi p-shahi linked an issue Dec 8, 2022 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

Images automagically compressed by Calibre's image-actions

Compression reduced images by 25.2%, saving 397.42 KB.

Filename Before After Improvement Visual comparison
src/.vuepress/public/favicon-16x16.png 1.38 KB 881 bytes -37.8% View diff
src/.vuepress/public/favicon-32x32.png 3.08 KB 2.58 KB -16.2% View diff
src/.vuepress/public/favicon-48x48.png 5.32 KB 4.86 KB -8.7% View diff
src/assets/libp2p-day-blog-header.png 547.11 KB 390.45 KB -28.6% View diff
src/assets/social-card.png 547.11 KB 390.45 KB -28.6% View diff
src/assets/webtransport_diagram.jpg 476.08 KB 393.47 KB -17.4% View diff

27 images did not require optimisation.

Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this written out - thanks guys.

A couple of thoughts:

  1. Are there other youtube videos we can embed or link to?
  2. Have we engaged the docs team to help general editing/review?

src/_blog/webtransport.md Outdated Show resolved Hide resolved
src/_blog/webtransport.md Outdated Show resolved Hide resolved
src/_blog/webtransport.md Outdated Show resolved Hide resolved
src/_blog/webtransport.md Outdated Show resolved Hide resolved
src/_blog/webtransport.md Outdated Show resolved Hide resolved
src/_blog/webtransport.md Outdated Show resolved Hide resolved
src/_blog/webtransport.md Outdated Show resolved Hide resolved
src/_blog/webtransport.md Outdated Show resolved Hide resolved
src/_blog/webtransport.md Show resolved Hide resolved
src/_blog/webtransport.md Outdated Show resolved Hide resolved
@BigLep
Copy link
Contributor

BigLep commented Dec 8, 2022

Also I didn't see a preview link for seeing what it looks like rendered

@p-shahi
Copy link
Member

p-shahi commented Dec 8, 2022

@BigLep the preview should be rendered now.

Co-authored-by: Steve Loeppky <stvn@loeppky.com>
src/_blog/webtransport.md Outdated Show resolved Hide resolved
src/_blog/webtransport.md Outdated Show resolved Hide resolved
src/_blog/webtransport.md Outdated Show resolved Hide resolved
@p-shahi
Copy link
Member

p-shahi commented Dec 8, 2022

Are there other youtube videos we can embed or link to?

Apart from https://www.youtube.com/watch?v=bmWLvS54-Zs I do not know of any other PL videos. Do you mean general WebTransport videos not created by us (which I would not want to include here.)

Have we engaged the docs team to help general editing/review?

Yes, Danny's already requested in this PR

@p-shahi p-shahi requested a review from BigLep December 8, 2022 20:23
src/_blog/webtransport.md Outdated Show resolved Hide resolved
src/_blog/webtransport.md Outdated Show resolved Hide resolved
src/_blog/webtransport.md Outdated Show resolved Hide resolved
src/_blog/webtransport.md Outdated Show resolved Hide resolved
src/_blog/webtransport.md Show resolved Hide resolved
src/_blog/webtransport.md Outdated Show resolved Hide resolved
src/_blog/webtransport.md Outdated Show resolved Hide resolved
src/_blog/webtransport.md Outdated Show resolved Hide resolved
src/_blog/webtransport.md Outdated Show resolved Hide resolved
src/_blog/webtransport.md Outdated Show resolved Hide resolved
Copy link
Member

@salmad3 salmad3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great blog! Also in favor of:

  • a general diagram for a WebSocket connection in libp2p.
  • another diagram to show the sending of datagrams in parallel to the CONNECT request.

src/_blog/webtransport.md Outdated Show resolved Hide resolved
src/_blog/webtransport.md Outdated Show resolved Hide resolved
src/_blog/webtransport.md Outdated Show resolved Hide resolved
src/_blog/webtransport.md Outdated Show resolved Hide resolved
p-shahi and others added 2 commits December 8, 2022 14:07
Co-authored-by: Danny Salman <salman.danny03@hotmail.com>
Co-authored-by: Danny Salman <salman.danny03@hotmail.com>
---
tags:
- browser, transport
title: WebTransport in libp2p
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being part of the Universal Browser Connectivity series, it is probably worth having a subheading:

WebTransport in libp2p
Part 1 of Universal Browser Connectivity

src/_blog/webtransport.md Outdated Show resolved Hide resolved
Co-authored-by: Danny Salman <salman.danny03@hotmail.com>
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 well written!

# WebTransport in libp2p

<!--
WebRTC (Browser to Server): Part 2 of Universal Browser Connectivity
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we should call it universal, it's only really universal if we're running TURN servers for WebRTC. Let's just call it Browser Connectivity.

Furthermore, I'm not sure if we should put it in a series anyway. WebTransport has very little to do with WebRTC (other than it works in the browser, but so does WebScoket).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a comment. I think we should make it a series of posts even though the two transports are unrelated.

src/_blog/webtransport.md Outdated Show resolved Hide resolved
src/_blog/webtransport.md Show resolved Hide resolved
src/_blog/webtransport.md Show resolved Hide resolved
src/_blog/webtransport.md Show resolved Hide resolved
src/_blog/webtransport.md Show resolved Hide resolved
src/_blog/webtransport.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 14.8%, saving 33.62 KB.

Filename Before After Improvement Visual comparison
src/assets/webtransport_diagram.png 227.89 KB 194.27 KB -14.8% View diff

32 images did not require optimisation.

@github-actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 9.3%, saving 55.40 KB.

Filename Before After Improvement Visual comparison
src/assets/libp2p_WebTransport_Blog_Header.png 366.25 KB 344.46 KB -5.9% View diff
src/assets/WebTransport-blog-post-diagram-1.png 227.89 KB 194.27 KB -14.8% View diff

33 images did not require optimisation.

Co-authored-by: Marten Seemann <martenseemann@gmail.com>
Copy link
Member

@p-shahi p-shahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crcle has provided the diagrams

@p-shahi p-shahi merged commit d9ebe36 into main Dec 19, 2022
@p-shahi p-shahi deleted the webtransport branch December 19, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebTransport Blog Post
5 participants