StreamProtocols are passed to Identify #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turuslan
requested changes
Sep 25, 2024
turuslan
approved these changes
Sep 26, 2024
|
|
||
| #include <libp2p/peer/stream_protocols.hpp> | ||
|
|
||
| namespace { |
There was a problem hiding this comment.
Suggested change
| namespace { | |
| namespace libp2p::protocol { |
| @@ -80,7 +80,9 @@ class IdentifyTest : public testing::Test { | |||
|
|
|||
| id_msg_processor_ = std::make_shared<IdentifyMessageProcessor>( | |||
| host_, conn_manager_, id_manager_, key_marshaller_); | |||
| identify_ = std::make_shared<Identify>(host_, id_msg_processor_, bus_); | |||
| IdentifyConfig config; | |||
| config.protocols = {kIdentifyProto}; | |||
There was a problem hiding this comment.
May use default
Suggested change
| config.protocols = {kIdentifyProto}; |
igor-egorov
reviewed
Sep 27, 2024
Comment on lines
+13
to
+15
| } // namespace | ||
|
|
||
| namespace libp2p::protocol { |
There was a problem hiding this comment.
Suggested change
| } // namespace | |
| namespace libp2p::protocol { |
The change completes the previous
ErakhtinB
force-pushed
the
2217-identify-config-protocols
branch
from
e0184fb
to
f51b471
Compare
igor-egorov
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.