Fixed broken links on js-libp2p getting started tutorial #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
reviewed
Oct 6, 2020
vasco-santos
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #80. It seems that the links to the
libp2p-nodejs.jsandlibp2p-browser.jsfiles constantly change, but hopefully the links that I put will not break in the future. Additionally, there is a broken link in the page that points to the definition of a multiaddress. As a fix, I instead pointed the link to the glossary entry for the multiaddress. Finally the output in the terminal shows the^Ccontrol character which I am guessing came from copying the terminal output after killing the ping server. This control character was removed from the output.