Library for IP -> ASN mapping #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
reviewed
May 28, 2020
| // AsnForIPv6 returns the AS number for the given IPv6 address. | ||
| // If no mapping exists for the given IP, this function will | ||
| // return an empty ASN and a nil error. | ||
| func (a *asnStore) AsnForIPv6(ip net.IP) (string, error) { |
There was a problem hiding this comment.
string is a weird return type? Asn's are positive integers
| panic(err) | ||
| } | ||
| } | ||
| printf("package %s\n\n", pkgName) |
There was a problem hiding this comment.
consider template, which may make this easier to read:
e.g. https://github.com/ipfs/go-datastore/blob/master/fuzz/cmd/generate/main.go#L60
| - [Contribute](#contribute) | ||
| - [License](#license) | ||
|
|
||
| ## Install |
There was a problem hiding this comment.
include a section on how to rebuild the DB
Stebalien
reviewed
May 28, 2020
asn.go
Outdated
|
|
||
| // NewAsnStore returns a `asnStore` that can be queried for the Autonomous System Numbers | ||
| // for a given IP address or a multiaddress which contains an IP address. | ||
| func NewAsnStore() (*asnStore, error) { |
There was a problem hiding this comment.
Is there any way to pre-generate this? This only adds 2MiB of data (not nice but not terrible), but this function takes way too long to run.
And update some deps
feat: use deferred initialization of the asnStore
|
Note this would also make the master branch non-empty, solve #2, and allow a simple |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ONLY supports IPv6 for now.