perf: replace the ipv6 map by an array of struct #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While starting
ipfs
this package used to take ~20ms while initing:That is because the map literal is actually creating a new map and adding entries one by one, which for such big map takes a while.
This PR moves this to a separate goroutine and use async.Once
to synchronise accesses. Almost completely removing it:Never is this map actually used as a map, the only consumer just iterate over it.
So we can use an array of structs containing
k
andv
instead, this pr make the init0.005ms
.