This repository has been archived by the owner on Jul 30, 2020. It is now read-only.
Add a dialer identity certificate #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
reviewed
Mar 2, 2020
| // add an identity certificate | ||
| dr.DialerIdentityCertificate = new(pb.Message_DialerIdentityCertificate) | ||
| dr.DialerIdentityCertificate.PublicKey = as.cpk | ||
| sgn, err := as.sk.Sign(varint.ToUvarint(*req.Dial.Nonce)) |
There was a problem hiding this comment.
can we sign directly from as.dialer.Peerstore().PrivKey(as.dialer.ID()).Sign(...) rather than making a copy of the private key on the autonat object?
Keeping key material in one place seems preferable.
|
Commenting in libp2p/go-libp2p#1480. |
|
This repo has now been deprecated. If we decide to pick this back up, we'll need to move it to https://github.com/libp2p/go-libp2p-autonat/. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Stebalien @willscott
For https://github.com/libp2p/go-libp2p-autonat/issues/10
Please let me know what you think.