Skip to content
This repository has been archived by the owner on May 11, 2022. It is now read-only.

Try dialing potential AutoNAT services on private addresses #45

Closed
Stebalien opened this issue Feb 25, 2020 · 3 comments
Closed

Try dialing potential AutoNAT services on private addresses #45

Stebalien opened this issue Feb 25, 2020 · 3 comments

Comments

@Stebalien
Copy link
Member

Before trusting an AutoNAT service, we should try dialing it on all unroutable addresses. We can do this by creating an ephemeral libp2p node (like the AutoNAT service does) but only feeding it unroutable addresses.

This should help tell is if the target is truely on a different network.

@willscott
Copy link
Contributor

If we aren't careful, this could potentially lead to a non-trivial amount of local network connection attempts. Many nodes will have private networks in the 3 private network spaces, so we're likely to be generating an ongoing trickle of local network connection attempts from most libp2p nodes in doing this

@Stebalien
Copy link
Member Author

So... we already do that, unfortunately . However, I agree we should do this as a last resort (ideally, the traceroute would handle it for us).

You may be interested in libp2p/go-libp2p#436 and the very long discussion.

@Stebalien
Copy link
Member Author

So... we already do that, unfortunately .

Really, given that, I'd expect this to be somewhat of a non-issue. The "local" connections should always finish first, so just looking at the remote address should work in almost all cases.

Actually, given that, I'm just going to close this.

willscott added a commit that referenced this issue Mar 13, 2020
Limiting autonat service responses/startup
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants