This repository has been archived by the owner on May 11, 2022. It is now read-only.
fix: a type switch nit #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Stebalien
commented
Apr 30, 2020
Stebalien
commented
willscott
reviewed
Apr 30, 2020
| @@ -188,7 +188,7 @@ func (as *AmbientAutoNAT) background() { | |||
| } | |||
|
|
|||
| case e := <-subChan: | |||
| switch e.(type) { | |||
| switch e := e.(type) { | |||
There was a problem hiding this comment.
is this free? I'd avoided doing it since the typed event wasn't needed in the localAddressesUpdated case.
There was a problem hiding this comment.
You are correct... by about a half a nanosecond. It saves a copy.
Up to you. I prefer this style because I like to avoid type panicing type assertions where possible.
| @@ -197,13 +197,14 @@ func (as *AmbientAutoNAT) background() { | |||
| } | |||
| } | |||
| case event.EvtPeerIdentificationCompleted: | |||
| peer = e.(event.EvtPeerIdentificationCompleted).Peer | |||
There was a problem hiding this comment.
remove the variable definition on line 174 since it's now unused, i think
willscott
approved these changes
Apr 30, 2020
Stebalien
force-pushed
the
fix/switch-nit
branch
from
f022e9f
to
dca3cb7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.