This repository has been archived by the owner on Sep 9, 2022. It is now read-only.
Timeout Stream Read #124
Merged
Timeout Stream Read #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
approved these changes
Dec 17, 2020
|
what's with the test failures? |
you need to gofmt; can you set your editor to do it automatically? |
Stebalien
approved these changes
Dec 17, 2020
|
@vyzo My new setup didn't have go fmt configured. Have fixed it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vyzo @Stebalien
I read through the circuit stream handling code and looks like this is the ONLY change we need to make.
Is there anything/any other incoming stream read we need to time out here ?