This repository has been archived by the owner on Sep 6, 2022. It is now read-only.
Interface to verify if a peer supports a protocol without making allocations #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarshkshah1992
changed the title
This was referenced May 8, 2020
Stebalien
previously approved these changes
May 8, 2020
peerstore/peerstore.go
Outdated
|
|
||
| // SupportsAnyProtocol returns true if the peer supports ATLEAST ONE of the given protocols and false otherwise. | ||
| // If the returned error is not nil, the result is indeterminate. | ||
| SupportsAnyProtocol(peer.ID, ...string) (bool, error) |
There was a problem hiding this comment.
What about FirstSupportedProtocol(peer.ID, ...string) (string, error)? This is what you want 99.9% of the time anyways and covers the new stream use-case.
There was a problem hiding this comment.
@Stebalien Great idea ! This is done.
|
@Stebalien Have made the interface change here and in the peerstore PR. Please take a look when you can. Thanks ! |
Stebalien
approved these changes
May 13, 2020
|
Merge and cut a minor release when ready. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: libp2p/go-libp2p-kad-dht#594.
In a lot of cases, we simply want to know if a peer supports any one protocol among a set of protocols.
In such cases, we currently end up doing:
However, this causes needless allocations as
SupportsProtocolsmakes an allocation for each protocol that is supported even if we don't actually need that information.This PR adds a
SupportsAnyProtocolAPI that allows clients to determine if the peer supports ANY of the given protocols without knowing which of the given protocols it actually supports.