-
Notifications
You must be signed in to change notification settings - Fork 75
add a context to OpenStream and NewStream #172
Conversation
CI is failing because this is a breaking API change. Obviously it is... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once we have all the related PRs in place.
All the transport PRs LGTM as well. @raulk can we get a final signoff on the change? This should have minimal to no impact on downstream users (unless they explicitly try to create a new stream on a specific connection, but most users just call |
@marten-seemann could you please announce the upcoming change in discuss.libp2p.io? |
Should we do that when we actually cut a release of go-libp2p? Status of the merge: |
Fixes #86, using option 1.
Associated PRs (These PRs will all need to be rebased after we've merged this PR and cut a new release):