Skip to content
This repository has been archived by the owner on Sep 6, 2022. It is now read-only.

add a context to OpenStream and NewStream #172

Merged
merged 2 commits into from
Dec 19, 2020
Merged

Conversation

@marten-seemann
Copy link
Contributor Author

CI is failing because this is a breaking API change. Obviously it is...

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once we have all the related PRs in place.

@Stebalien
Copy link
Member

All the transport PRs LGTM as well. @raulk can we get a final signoff on the change? This should have minimal to no impact on downstream users (unless they explicitly try to create a new stream on a specific connection, but most users just call host.NewStream(...).

@raulk
Copy link
Member

raulk commented Dec 18, 2020

@marten-seemann could you please announce the upcoming change in discuss.libp2p.io?

@marten-seemann marten-seemann merged commit 83ac1d3 into master Dec 19, 2020
@marten-seemann
Copy link
Contributor Author

@marten-seemann could you please announce the upcoming change in discuss.libp2p.io?

Should we do that when we actually cut a release of go-libp2p?

Status of the merge:
All PRs merged, expect for libp2p/go-libp2p-webrtc-direct#35 (build is broken, repo doesn't seem to be maintained) and libp2p/go-libp2p-kad-dht#701 (depends on go-libp2p).
We might want to make sure that go-yamux and go-mplex respect the context before actually cutting a new release of go-libp2p (with the current changes, they just conform to the new interface but ignore the context). Still waiting for PRs to get reviewed on the respected repos.

@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenStream needs to take a context
3 participants