feat(bootstrap): autobootstrap #402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Auto bootstrap on start. 2. Make `Bootstrap(ctx)` trigger a bootstrap but not _start_ the bootstrapping process.
Stebalien
commented
Nov 1, 2019
| // Bootstrap i | ||
| func (dht *IpfsDHT) startBootstrapping() error { | ||
| // scan the RT table periodically & do a random walk on k-buckets that haven't been queried since the given bucket period | ||
| dht.proc.Go(func(proc process.Process) { |
There was a problem hiding this comment.
I figured I'd let the process management system manage the bootstrap process while we were at it.
| case <-time.After(dht.bootstrapCfg.SelfQueryInterval): | ||
| case <-ctx.Done(): | ||
| return | ||
| if walkSelf { |
There was a problem hiding this comment.
I combined these into a single loop.
- We always want to finish
selfWalkbefore checking the buckets. - It doesn't make sense to walk self if we're not going to immediately fill in the empty buckets.
|
Hey @Stebalien Have taken this to completion in #403 with some changes. Please take a look when you can. We can close this PR after 403 goes in. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootstrap(ctx)trigger a bootstrap but not start the bootstrapping process.Alternative to #401.
Unfortunately, getting the tests to pass is difficult. We may need some option to not automatically start the DHT.