fix: always send the result channel when triggering a refresh #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, we'll just return a channel that will never be signaled.
vyzo
reviewed
Dec 13, 2019
| case dht.triggerRtRefresh <- res: | ||
| default: | ||
| } | ||
| dht.triggerRtRefresh <- res |
There was a problem hiding this comment.
is the triggerRtRefresh channel buffered?
There was a problem hiding this comment.
It's not. But, the reader drains all the reqs on the channel before proceeding so it can signal the result of the refresh to all "simultaneous" callers.
However, what could happen here is that if a refresh is already in progress, all callers of RefreshRoutingTable will block till the current refresh round finishes and then trigger yet another refresh.
@Stebalien Are we okay with that ?
There was a problem hiding this comment.
That's the intended behavior, at least for the moment. I want to be able to:
- Connect to a peer.
- Trigger a refresh that uses that peer.
That means I want the refresh to start after I call the function and I don't want to count any refreshes that started before.
hacdias
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, we'll just return a channel that will never be signaled.