fix: improve error handling in dual dht #582

Stebalien · 2020-04-10T02:32:12Z

FindPeer should succeed as long as we find the peer in one DHT.
If we get a kbucket error from one DHT, return the error from the other DHT.
Avoid returning the same error twice.

1. FindPeer should succeed as long as we find the peer in one DHT. 2. If we get a kbucket error from one DHT, return the error from the other DHT. 3. Avoid returning the same error twice.

willscott · 2020-04-10T02:37:03Z

dual/dual.go

+
+func combineErrors(erra, errb error) error {
+	// if the errors are the same, just return one.
+	if erra == errb {


can 2 instances of the same error not be ==? will this do string equality (which should be safe)?

This won't do string equality, but I really just care if they're the same. E.g., "ErrNotFound", "ErrNotSupported", etc. Unfortunately, this is just a heuristic to improve the errors a bit.

fix: improve error handling in dual dht

04ed71c

1. FindPeer should succeed as long as we find the peer in one DHT. 2. If we get a kbucket error from one DHT, return the error from the other DHT. 3. Avoid returning the same error twice.

Stebalien requested a review from willscott April 10, 2020 02:32

willscott approved these changes Apr 10, 2020

View reviewed changes

Stebalien merged commit 7e74bc8 into master Apr 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: improve error handling in dual dht #582

fix: improve error handling in dual dht #582

Stebalien commented Apr 10, 2020

willscott Apr 10, 2020

Stebalien Apr 10, 2020

fix: improve error handling in dual dht #582

fix: improve error handling in dual dht #582

Conversation

Stebalien commented Apr 10, 2020

willscott Apr 10, 2020

Choose a reason for hiding this comment

Stebalien Apr 10, 2020

Choose a reason for hiding this comment