Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds an option to allow passing your own instance of provider manager when constructing a DHT.
In Hydra, we have many heads (up to 200 currently) that have their own DHT instances and corresponding provider managers. They are all caching records and performing GC on a shared datastore.
I'd like to avoid multiple GC runs and out-of-sync caches. In this PR I seek to fix this by enabling the DHT to accept a provider manager as an option, allowing a single provider manager to be used for all hydra heads.
We've defined a
ProviderStore
interface thatProviderManager
(already) implements. By using an interface we give ourselves room to pass a custom implementation (at a later date maybe...since we will encounter the problem again when using the postgres datastore to share between Hydras, in addition to Hydra heads).dht.ProviderManager
property in favor of adht.ProviderStore()
function.