Dont count connection times in usefulness #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if we can merge this until we get the load balanced bootstrapping in. One of the ideas behind this metric was penalizing peers that repeatedly disconnect (because they're likely overloaded). |
|
@Stebalien Agreed. Let's wait till that goes in. |
Stebalien
force-pushed
the
feat/no-connection-time-usefulness
branch
from
c390fb7
to
23a315d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the other hand, this could slow down queries for lower CPLs for now if the other guy keeps disconnecting from us because we are not in their Routing Table.