allow overwriting builtin dual DHT options #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
approved these changes
Aug 20, 2020
dual/dual.go
Outdated
| if wan.Mode() != dht.ModeClient { | ||
| lanOpts = append(lanOpts, dht.Mode(dht.ModeServer)) | ||
| cfg.lan = append([]dht.Option{dht.Mode(dht.ModeServer)}, cfg.lan...) |
There was a problem hiding this comment.
Why not flip this to be cfg.lan = append (cfg.lan, DHT.Mode(dht.ModeServer)?
There was a problem hiding this comment.
For example, users can reasonably expect to pass dht.Mode(dht.ModeAuto) into the constructor. Appending this after ModeServer will mean that we start the LAN DHT in ModeAuto which is bad.
I get the desire to have user options trump the default options. Maybe we need a ForceWAN() and ForceLAN() option or something to figure out when a user really wants to clobber the defaults.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed by tests to disable things like diversity filters for WANs.