findpeer should work even on peers that are not part of DHT queries #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dialed as part of the query under the queryfilter
When performing queries query the next peer if it happens to match the target even if it would normally be excluded by the queryfilter. This is meant for fixing FindPeer, but for ease of implementation is applying more broadly to queries like GetClosestPeers as well.
Stebalien
approved these changes
Apr 1, 2021
Not sure if it's worth fixing separately from #584 though. It'd be more "correct" to have a special path through the query logic for FindPeer (e.g. even just a field in the query struct |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #708
It looks like when we switched to using
QueryFiltersto remove relayed peers or other undesirables from our queries we ended up effectingFindPeerbecauseFindPeerisn't treated like a normal put/get but as an "accidental" extension of a normal query.See #584 for more info on the specialness of
FindPeer