-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add basic tracing #769
Conversation
23090b7
to
b07488e
Compare
5e10f79
to
c6dea86
Compare
Any reasons not to add a context as argument to go-libp2p-kad-dht/rtrefresh/rt_refresh_manager.go Lines 103 to 121 in 471e058
|
@guillaumemichel thx for the review <3
If we start accepting contextes we will have to do a dance of keeping a tally of how many calls still want the refresh, because a cancel of one of them shouldn't cancel the full refresh if other peoples are relying on it. I could add a context here but it would make the code more complex for what seems a small benefit over using |
9605ac9
to
ef4c73a
Compare
Removed noisy traces and added tracing to RtRefreshManager
ef4c73a
to
a75a333
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I am OK with merging, we can always add more spans later if needed.
No description provided.