Add example of a find peer query using go-kademlia #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennis-tra
commented
Aug 14, 2023
Comment on lines
+40
to
+42
| qSubs map[query.QueryID]chan<- kad.Response[key.Key256, ma.Multiaddr] | ||
| qSubsLk sync.RWMutex | ||
| qSubCnt uint64 |
There was a problem hiding this comment.
I still think this would better handled in go-kademlia
There was a problem hiding this comment.
Yeah it would be nicer but the compromise is that the logic for stopping the query in the event loop has to be injected
dennis-tra
commented
Aug 14, 2023
| ch, ok := d.qSubs[tev.QueryID] | ||
| if !ok { | ||
| // we have lost the query waiter somehow | ||
| d.kad.StopQuery(ctx, tev.QueryID) |
There was a problem hiding this comment.
StopQuery returns an error but in go-kademlia this is always nil
dennis-tra
commented
Aug 14, 2023
| // found the node we were looking for | ||
| d.kad.StopQuery(ctx, qid) | ||
| pid := peer.AddrInfo{ | ||
| ID: peer.ID(found.ID().(nodeID)), |
There was a problem hiding this comment.
It would be cooler if we didn't need to do this type cast here
|
This looks good. Can we stretch further and implement get providers? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.