Use MapDatastore for provider backend tests instead of leveldb #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennis-tra
force-pushed
the
v2-go121-fix-windows-2
branch
from
d064e82
to
985b12c
Compare
dennis-tra
changed the title
dennis-tra
commented
Sep 13, 2023
| @@ -71,23 +70,13 @@ func TestProvidersBackend_GarbageCollection(t *testing.T) { | |||
| // advance clock half the validity time and check if record is still there | |||
| clk.Add(cfg.ProvideValidity / 2) | |||
|
|
|||
| // sync datastore to have all put/deletes visible | |||
| err = b.datastore.Sync(ctx, ds.NewKey("/")) | |||
There was a problem hiding this comment.
Didn't have an effect anyway: https://github.com/ipfs/go-ds-leveldb/blob/8175c02d2a9107dd73b1cdeb315ae6fe7557e86a/datastore.go#L94
There was a problem hiding this comment.
syncWrites was set to true in the initializer: https://github.com/ipfs/go-ds-leveldb/blob/8175c02d2a9107dd73b1cdeb315ae6fe7557e86a/datastore.go#L62
There was a problem hiding this comment.
Maybe we were filling the read cache? https://github.com/syndtr/goleveldb/blob/126854af5e6d8295ef8e8bee3040dd8380ae72e8/leveldb/opt/options.go#L702
iand
approved these changes
Sep 13, 2023
iand
added a commit
that referenced
this pull request
Sep 16, 2023
* v2: upgrade to go1.21 * Add uci config * Use newer uci actions * Use v2 working directory in actions * Set go-version input in actions * Set go-version input in actions * Use go 1.20.8 in actions * Use go 1.21.1 and relative working directory * Try default working directory on job * Remove uci.yaml which is not supported yet * Try default working directory on job * Try default working directory as input * Restore uci.yaml * Restore uci.yaml * Use modified go-check * Use modified go-test * Fix go-test * Fix go-test * Fix go-test * Restore libp2p 0.30.0 * go mod tidy * Remove nil error return from DefaultConfig * use mock clock for IPNS record generation (#894) * Use MapDatastore for provider backend tests instead of leveldb (#896) * revert some merge residuals * style: minor coding clean up (#898) * remove superfluous type conversion * add tiny example test * unexport type conversion helpers * Target go language version 1.20 and add 1.20.8 to build matrix * Target go language version 1.20 and add 1.20.8 to build matrix * WIP --------- Co-authored-by: Dennis Trautwein <git@dtrautwein.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
leveldb synchronization seems to behave differenlty on Windows vs. Linux/MacOS which lead to failing tests.