Remove Jaeger dependency #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennis-tra
force-pushed
the
v2-remove-jaeger
branch
4 times, most recently
from
18dd09a
to
96f09ea
Compare
dennis-tra
commented
Sep 18, 2023
| @@ -73,16 +72,6 @@ func (w *notificationWatcher) Expect(ctx context.Context, expected RoutingNotifi | |||
| } | |||
| } | |||
|
|
|||
| // TracingTelemetry may be used to create a Telemetry that traces a test | |||
iand
approved these changes
Sep 18, 2023
dennis-tra
force-pushed
the
v2-remove-jaeger
branch
from
96f09ea
to
197734b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes tracing to use the OpenTelemetry protocol which is also recommended by Jaeger.
go.opentelemetry.io/otel/exporters/jaeger:Works with the following docker command:
Note that
jaegertracing/all-in-oneversion1.49is newer than version1.6which we often used in the past (5 years old).