Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid panic when node is re-added to probe list #902

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

dennis-tra
Copy link
Contributor

@iand could you take over, refine, and fix?

@dennis-tra dennis-tra marked this pull request as draft September 18, 2023 15:11
@iand iand changed the title Add test that leads to panic of NodeValueList fix: avoid panic when node is re-added to probe list Sep 18, 2023
@iand iand self-assigned this Sep 18, 2023
@iand iand added the v2 All issues related to the v2 rewrite label Sep 18, 2023
@iand
Copy link

iand commented Sep 18, 2023

@dennis-tra please take a look at the fix

@dennis-tra dennis-tra marked this pull request as ready for review September 18, 2023 16:43
@dennis-tra dennis-tra merged commit 156aab2 into v2-develop Sep 18, 2023
11 checks passed
@dennis-tra dennis-tra deleted the v2-value-list-panic branch September 18, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2 All issues related to the v2 rewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants