fix: garbage collection test race condition #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennis-tra
force-pushed
the
v2-coord-addr-gc-failing-test
branch
3 times, most recently
from
4c6011e
to
817ca58
Compare
dennis-tra
changed the title
dennis-tra
force-pushed
the
v2-coord-addr-gc-failing-test
branch
from
817ca58
to
d57e2b4
Compare
dennis-tra
force-pushed
the
v2-coord-addr-gc-failing-test
branch
from
d57e2b4
to
765a04d
Compare
iand
approved these changes
Sep 19, 2023
iand
added a commit
that referenced
this pull request
Sep 19, 2023
* Decouple coord package from addressing * Go fmt * fix: garbage collection test race condition (#904) Moved ticker initialization outside the garbage collection goroutine. There was a race condition between advancing the mocked time in TestProvidersBackend_GarbageCollection and the initialization of the ticker that triggers the garbage collection runs. It happened that we were advancing the time without the ticker being initialized. Hence, advancing the time hasn't had any effect. In this PR, I moved the ticker initialization outside the garbage collection goroutine. This means the ticker will be registered with the MockClock object after StartGarbageCollection returns. Calls to mockClock.Add will therefore trigger the ticker. * Fix test flakes that wait for routing events (#905) * Increase test iterations to trigger flake * Add failfast * Replace routing notification channel with a RoutingNotifier type * Remove unused code * Remove test count --------- Co-authored-by: Dennis Trautwein <git@dtrautwein.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved ticker initialization outside the garbage collection goroutine. There was a race condition between advancing the mocked time in
TestProvidersBackend_GarbageCollectionand the initialization of the ticker that triggers the garbage collection runs. It happened that we were advancing the time without the ticker being initialized. Hence, advancing the time hasn't had any effect.In this PR, I moved the ticker initialization outside the garbage collection goroutine. This means the ticker will be registered with the MockClock object after
StartGarbageCollectionreturns. Calls tomockClock.Addwill therefore trigger the ticker.