Clean up DHT test helpers #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennis-tra
reviewed
Sep 19, 2023
v2/routing.go
Outdated
| } | ||
|
|
||
| // PutValueLocal stores a value in the local datastore without querying the network. | ||
| func (d *DHT) PutValueLocal(ctx context.Context, key string, value []byte) error { |
There was a problem hiding this comment.
rather unexport and only export when it's needed to decrease API surface?
v2/routing.go
Outdated
| } | ||
|
|
||
| // GetValueLocal retrieves a value from the local datastore without querying the network. | ||
| func (d *DHT) GetValueLocal(ctx context.Context, key string) ([]byte, error) { |
There was a problem hiding this comment.
rather unexport and only export when it's needed to decrease API surface?
v2/routing_test.go
Outdated
Comment on lines
20
to
25
| _, pub, _ := crypto.GenerateEd25519Key(rng) | ||
| v, err := crypto.MarshalPublicKey(pub) | ||
| require.NoError(t, err) | ||
|
|
||
| id, err := peer.IDFromPublicKey(pub) | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
in handlers_test.go is a newPeerID function
There was a problem hiding this comment.
nice. I'd like to consolidate all these helpers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #912