Move coord packages to internal #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iand
commented
Sep 20, 2023
|
|
||
| import "fmt" | ||
|
|
||
| // A ConfigurationError is returned when a component's configuration is found to be invalid or unusable. |
There was a problem hiding this comment.
I think we should be using typed errors throughout so I brought this over from go-kademlia
iand
commented
Sep 20, 2023
| "github.com/libp2p/go-libp2p-kad-dht/v2/coord" | ||
| "github.com/libp2p/go-libp2p-kad-dht/v2/coord/routing" | ||
| "github.com/libp2p/go-libp2p-kad-dht/v2/kadt" | ||
| "github.com/libp2p/go-libp2p-kad-dht/v2/internal/coord/routing" |
There was a problem hiding this comment.
Used for the Routing Table. I need to replicate the necessary interface here
There was a problem hiding this comment.
Defined interface in kadt package since it is part of the bridge between libp2p and go-kademlia types
iand
changed the title
|
Had to move kadt back out of internal since the RoutingTable uses kadt.Key and kadt.PeerID so clients supplying their own routing table implementation need access to those types too. |
dennis-tra
approved these changes
Sep 20, 2023
iand
added a commit
that referenced
this pull request
Sep 21, 2023
* Improve query capabilities * go mod tidy * Review feedback * go mod tidy * Move coord packages to internal (#933) * Move coord and kadt packages to internal * go mod tidy * go fmt * Move kadt out of internal and add RoutingTable interface
iand
added a commit
that referenced
this pull request
Sep 25, 2023
* Improve query capabilities * go mod tidy * Review feedback * go mod tidy * Move coord packages to internal (#933) * Move coord and kadt packages to internal * go mod tidy * go fmt * Move kadt out of internal and add RoutingTable interface * Add explore state machine to expand population of routing table * Refactor schedule into separate type * Add generation of random peer id for a given cpl * go mod tidy * Add prefixmap generator * Use constants for various query ids * go mod tidy * Wire explore state machine into routing behaviour * Remove some unnecessary conversions * PR review updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved coord and sub packages to internal to reduce API surface and allow more radical refactoring in the future.
Need to double-check that no internal types are expected in method signatures or return values in the v2 root packageBranched from #932 since that touched a lot of the same packages