Logging improvements #941
Merged
Logging improvements #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennis-tra
approved these changes
Sep 28, 2023
Comment on lines
+16
to
+21
| AttrKeyError = "error" | ||
| AttrKeyPeerID = "peer_id" | ||
| AttrKeyKey = "key" | ||
| AttrKeyCacheHit = "hit" | ||
| AttrKeyInEvent = "in_event" | ||
| AttrKeyOutEvent = "out_event" |
There was a problem hiding this comment.
If they are only used in the tele package we could unexport them
There was a problem hiding this comment.
They're designed to be used wherever we need them, such as logging an attribute
| d.log.Warn(msg, tele.LogAttrError(err)) | ||
| return | ||
| } | ||
| d.log.With(args...).Warn(msg, tele.LogAttrError(err)) |
There was a problem hiding this comment.
not necessary, but now that we have helper methods for logging error messages we could use the more performant LogAttrs method here. Error logs shouldn't live in the hot path anyway so feel free to ignore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the logging a little more consistent and adds debug logging for key routing events to help with testing during integration.