Implement SearchValue/GetValue #942
Conversation
dennis-tra
force-pushed
the
v2-issue-911-search-value
branch
from
8b4b920
to
2779cff
Compare
|
Related: #945 |
| // acknowledgement that the other peer has received the data is not | ||
| // guaranteed. The data will be flushed at this point, but the remote might | ||
| // not have handled it yet. Therefore, we use "EventuallyWithT" here. | ||
| assert.EventuallyWithT(t, func(t *assert.CollectT) { |
There was a problem hiding this comment.
We control both peers in this test so can't we deterministically query the remote peer to see if the data has been handled?
There was a problem hiding this comment.
In the function body, I'm querying the remote peer to see if the data has been handled. Because of the reasons in the comment above I'm not sure how we can do this deterministically.
I could pass a custom Backend/Datastore to d2 and use a wait group to block until it's stored on the other peer 🤔
|
|
||
| func TestDHT_Bootstrap_no_peers_configured(t *testing.T) { | ||
| // TIMING: this test is based on timeouts - so might become flaky! | ||
| ctx := kadtest.CtxShort(t) |
There was a problem hiding this comment.
We could run timing based tests for longer. CtxShort is for tests that we expect to complete quickly - either the result is processed quickly or it never happens because something is broken. We could have another helper function that always returns a context with a deadline just before the test deadline so the test has the full allotted time to complete
There was a problem hiding this comment.
Both of the timing-sensitive tests run very fast. It's just that the state doesn't manifests at the remote peers immediately.
dennis-tra
force-pushed
the
v2-issue-911-search-value
branch
from
97e9fbe
to
b031121
Compare
fixes #911
fixes #912
Todo
// TODO