tag kbucket peers for better connection closing #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be good enough, though the failing test seems odd (but fairly certain it was there before this PR) |
Kubuxu
approved these changes
Oct 9, 2017
|
It seems like Travis has just hanged the tests. Go should timeout after 10min, ahh. Travis also does 10min so we have no idea if it was Travis or tests. |
Stebalien
approved these changes
Oct 10, 2017
|
Yes, it would make sense to mark few peers per bucket with higher priority, this way might keep few in each bucket instead of loosing whole bucket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.