chore: correctly merge fix from #976 #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: fix connectedness
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Aug 21, 2024
v0.26.0 missed some commits, checking if icluding them helps with failing helia interop libp2p/go-libp2p-kad-dht#980
This was referenced Aug 21, 2024
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Aug 21, 2024
v0.26.0 missed some commits, checking if icluding them helps with failing helia interop libp2p/go-libp2p-kad-dht#980
MarcoPolo
approved these changes
Aug 21, 2024
Closed
|
Thanks for sorting this out @lidel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to correctly merge fix from #976 into
masterbranch.It was missed when releasing v0.26.0:
@MarcoPolo you may have full context, but my guess how this happened (could be something else):
steb/update-libp2ptomastersteb/update-libp2psteb/update-libp2pbut it never ended up inmasterbranch and did not end up in v0.26.0 release.